Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linalg.helpers] Rename template parameter for poison pills #7501

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[linalg.helpers] Rename template parameter for poison pills #7501

merged 1 commit into from
Dec 17, 2024

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Dec 17, 2024

This avoids reusing T which is also used for the type of the subexpression E.

Fixes #7494

@jwakely
[linalg.helpers] Rename template parameter for poison pills
58fe82c 
This avoids reusing `T` which is also used for the type of the
subexpression E.

Fixes cplusplus#7494
jensmaurer
jensmaurer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

@tkoeppe tkoeppe merged commit 0131e01 into cplusplus:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[linalg.helpers] too many T
3 participants
@jwakely @jensmaurer @tkoeppe